Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sizes attribute on source? #44

Open
K3vinF opened this issue Mar 16, 2021 · 0 comments
Open

Allow sizes attribute on source? #44

K3vinF opened this issue Mar 16, 2021 · 0 comments

Comments

@K3vinF
Copy link

K3vinF commented Mar 16, 2021

If I understand correctly, each within a element is allowed to have a size attribute?

-> https://developer.mozilla.org/en-US/docs/Web/HTML/Element/source

However it looks like react-responsive-picture doens't pass the sizes attribute through to the source?

Reading the documentation this seems to be by design?

For each source you can send an object containing srcSet, media and type although the last two are optional.

Was this a deliberate call, or has this need never arisen? Would you be open to an MR that adds this feature to the module?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant