Skip to content
This repository has been archived by the owner on Aug 19, 2021. It is now read-only.

build-containers #104

Open
jinseo-jang opened this issue Aug 24, 2020 · 2 comments
Open

build-containers #104

jinseo-jang opened this issue Aug 24, 2020 · 2 comments

Comments

@jinseo-jang
Copy link

in build-containers scripts, docker build command should be adjusted to find proper Dockerfiles.
docker build -t crystal-service ../ecsdemo-crystal or docker build -t crystal-service ~/environment/ecsdemo-crystal

@jeeslo
Copy link

jeeslo commented Aug 31, 2020

Is this an actual issue or an improvement? If I am not mistaken, following the workshop instructions you are intended to run the generated script from the ~/environment path, hence the docker build commands work as expected. In any case, I agree that its a quick change that could avoid the script failing out should someone decides to run it from somewhere else.

@jinseo-jang
Copy link
Author

yes. it can be an improvement in case learners are just lost where to execute that script.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants