Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting all NaN if some rows have zero expression #11

Open
wdecoster opened this issue Nov 27, 2017 · 0 comments
Open

Getting all NaN if some rows have zero expression #11

wdecoster opened this issue Nov 27, 2017 · 0 comments

Comments

@wdecoster
Copy link

It took me a while to figure it out (although in hindsight it seems obvious) but when the dat DataFrame contains rows which are entirely zero the result returned by combat() will contain all NaNs.

Perhaps it's worth to a) specify that in the manual or b) check for that and drop those rows (with a warning) while running the function. If you think b) makes sense I would be happy to add that and open a PR.

Unrelated, it seems that ComBat() in R has changed, the line
cdata = ComBat(dat=edata, batch=as.factor(pheno$batch), mod=mod, numCov=match("age", colnames(mod)))
returns
Error in ComBat(dat = edata, batch = as.factor(pheno$batch), mod = mod, : unused argument (numCov = match("age", colnames(mod))) Execution halted

Cheers,
Wouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant