Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log message debounce #406

Open
Mododo opened this issue Nov 4, 2024 · 1 comment
Open

log message debounce #406

Mododo opened this issue Nov 4, 2024 · 1 comment
Labels
C-cli Node CLI module C-consesus Consesus module enhancement New feature or request
Milestone
Stable Testnet

Comments

@Mododo
Copy link
Member

Mododo commented Nov 4, 2024

We have some error messages that we neither want to hide totally under DEBUG level nor print several times per second. Some examples in mempool:

  • InputBuffer is not yet initialized during sync after start and evicts any received ext_in msgs
  • network error on sending broadcasts to resolved but disconnected peer

Add global map in tycho_utils that stores formatted strings for tracing outputs for some duration from node config. On first insert, log is printed. Same string should appear in log again only after duration passes. Map should not store messages for disabled log levels.

It's ok that map should be used with care to store only repeatable messages.
@Mododo
Copy link
Member Author

Mododo commented Nov 4, 2024

previous work #349

@Rexagon Rexagon added enhancement New feature or request C-cli Node CLI module C-consesus Consesus module labels Nov 7, 2024
@Rexagon Rexagon added this to the Stable Testnet milestone Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-cli Node CLI module C-consesus Consesus module enhancement New feature or request
Projects
None yet
Milestone
Stable Testnet
Development

No branches or pull requests
2 participants
@Rexagon @Mododo