Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descriptor_parse: crash with pk(xprv.../*) #70

Open
brunoerg opened this issue Dec 18, 2024 · 2 comments
Open

descriptor_parse: crash with pk(xprv.../*) #70

brunoerg opened this issue Dec 18, 2024 · 2 comments
Labels
crash

Comments

@brunoerg
Copy link
Owner

Input: pk(xprv9s21ZrQH143K31xYSDQpPDxsXRTUcvj2iNHm5NUtrGiGG5e2DtALGdso3pGz6ssrdK4PFmM8NSpSBHNqPqm55Qn3LqFtT2emdEXVYsCzC2U/*)

Bitcoin successfully parses it and rust-miniscript returned error "Public keys must be 64/66/130 characters in size"/"pubkey string should be 66 or 130 digits long, got: 113".
@brunoerg brunoerg added the crash label Dec 18, 2024
@apoelstra
Copy link

Neat! Can you move/copy this to rust-miniscript. I think this is a gap in our definition of DescriptorPublicKey.

@brunoerg brunoerg mentioned this issue Dec 18, 2024
Open
@brunoerg
Copy link
Owner Author

Neat! Can you move/copy this to rust-miniscript. I think this is a gap in our definition of DescriptorPublicKey.

Yes! Done. rust-bitcoin/rust-miniscript#785

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@apoelstra @brunoerg