Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goroutine listening on channel "stop" never exits #17

Open
goopsie opened this issue Jun 20, 2019 · 1 comment · Fixed by omatztw/dgvoice#1 · May be fixed by #23
Open

Goroutine listening on channel "stop" never exits #17

goopsie opened this issue Jun 20, 2019 · 1 comment · Fixed by omatztw/dgvoice#1 · May be fixed by #23

Comments

@goopsie
Copy link

goopsie commented Jun 20, 2019 •
edited
Loading

After the audio is done playing, Nothing happens to the goroutine that's listening on the "stop" channel
@yuko1225
Copy link

I notice that too. And it cause problem because if you start another playback, you won't be able to stop the playback since it sending signal to another instance which already dead.

I end up set up another channel to notify that goroutine to exit after function return

omatztw added a commit to omatztw/dgvoice that referenced this issue Feb 23, 2022
@omatztw
Stop goroutine when audio is done playing.
0315370 
Fix bwmarrin#17
@omatztw omatztw mentioned this issue Feb 23, 2022
Merged
omatztw added a commit to omatztw/dgvoice that referenced this issue Feb 23, 2022
@omatztw
Merge pull request #1 from omatztw/fix/bwmarrin#17-listening-stop-for…
10123a3 
…ever

Stop goroutine when audio is done playing.
@omatztw omatztw linked a pull request Feb 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yuko1225 @goopsie