New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Critical Error #5

Open

dingsp opened this issue Mar 17, 2020 · 1 comment

dingsp commented Mar 17, 2020

fc_malloc/malloc3.cpp

Line 802 in 7a56cf9

auto claim_pos = rb.claim( claim_num );

May be too many thread claims and there are two threads get the same index in the ring buffer, so I think it may cause serious error.

Author

dingsp commented Mar 17, 2020 •

edited

Loading

I think claim block first and then compare claim_pos with _write_pos is safe.
if claim_pos <= _write_pos, we can read the ring buffer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment