Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic builder breaks when baritone walks over a candle #4618

Open
EvModder opened this issue Jan 15, 2025 · 3 comments
Open

Schematic builder breaks when baritone walks over a candle #4618

EvModder opened this issue Jan 15, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@EvModder
Copy link

How to reproduce

Easiest method is to do #build some_mapart_containing_candles, baritone will start placing candles/etc., but the moment it walks on top of a candle it stops with an error. Funnily enough, the error will be for "missing material: candle" even when the entire hotbar/inventory is filled with candles. If I move the bot off the candle and type #resume it will continue, start placing candles again, and likely get stuck a moment later when it inevitably moves and steps on another one.

Info

Operating system: Windows10 and MacOS (haven't tested on Linux)
Java version: 23
Minecraft versions tested: 1.20.6, 1.21.1, 1.21.4
Baritone version: baritone fabric api 1.11.1-1
Other mods: Not needed to reproduce

Logs

IMO these are not needed, since there is no error in them, but will attach if requested.

Modified settings

Not needed for repro. (issue happens on a clean install, with no settings.txt file in the baritone folder)

checklist: done

@EvModder EvModder added the bug Something isn't working label Jan 15, 2025
@EvModder EvModder changed the title Schematic builder breaks instantly when baritone walks over a candle Schematic builder breaks when baritone walks over a candle Jan 15, 2025
@ZacSharp
Copy link
Collaborator

I guess this is a consequence of a mixture of known problems

  1. The really big problem. Baritone has to use a hack to determine what you can place (see here for a short explanation), and it seems like that hack doesn't detect candles as placeable when you stand on one.
  2. A less severe one. If Baritone knows there are wrong blocks nearby it won't scan for more mismatches and if it doesn't find anything to do it fails. This one should actually be an easier one, if you get over the fact that working on the builder is not nice.

And to make it clear what you can expect here: Cause known, problem acknowledged, nobody known who would fix it, contributions welcome.

Since I plan on eventually getting a working builder into Baritone this is bug is effectively on my todo list, but getting done with that is another story, especially given that I currently work on Baritone maybe 1h per week on average due to time constraints and if something takes considerable time to even get started, chances are I'll postpone it.

@EvModder
Copy link
Author

Understandable.

I was able to get a local clone working with a pretty BS hack - disabling baritone's checks for isOnGround, isSneaking, and strictness for block mismatch. Seems to work for my 2D (mostly carpet) case, but I'm sure it'll break baritone builder for other stuff.

@ZacSharp
Copy link
Collaborator

Can you please share the diff? Even if the full fix won't make it in it might still be useful information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants