Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build from Source shows version 5.0.1 rather than 5.0.3 #352

Open
spdavern opened this issue Jan 3, 2025 · 1 comment
Open

Build from Source shows version 5.0.1 rather than 5.0.3 #352

spdavern opened this issue Jan 3, 2025 · 1 comment
Labels

Comments

@spdavern
Copy link

spdavern commented Jan 3, 2025

Expected Behavior

Running cadet-cli --version should give 5.0.3

Actual Behavior

▶ cadet-cli --version
This is cadet-cli version 5.0.1 (master branch)
Built from commit 5333e26085715ecd8ecc9106c1ab0692e28c185e
Build variant Release
CADET homepage: <https://cadet.github.io>
Fork CADET on GitHub: <https://github.com/cadet/CADET-Core>
Report bugs to the issue tracker on GitHub or <[email protected]>
See the accompanying LICENSE.txt, AUTHORS.md files

Steps to Reproduce the Problem

Installing CADET-Core using conda install -c conda-forge cadet gives the error:

▶ conda install -c conda-forge cadet
Channels:
 - conda-forge
 - defaults
Platform: osx-arm64
Collecting package metadata (repodata.json): done
Solving environment: failed

PackagesNotFoundError: The following packages are not available from current channels:

  - cadet

Current channels:

  - https://conda.anaconda.org/conda-forge
  - defaults

So, I successfully used the instructions in BUILD-OSX.md to build from source. The resulting CADET seems to be fully functional but shows the wrong version despite all the changes in commit 7dc64b0 present in commit 5333e26 used for build.

  1. Follow instructions in BUILD-OSX.md
  2. Run cadet-cli --version

Specifications

  • Version: 5.0.3
  • Platform: osx-arm64 - Apple Macbook Pro with the Apple M3 Max chip
  • Subsystem:

▶ cmake --version
cmake version 3.31.3
▶ gcc --version
Apple clang version 16.0.0 (clang-1600.0.26.6)
Target: arm64-apple-darwin23.6.0
Thread model: posix
▶ brew info hdf5
==> hdf5: stable 1.14.5 (bottled)
▶ brew info tbb
==> tbb: stable 2022.0.0 (bottled)
▶ brew info eigen
==> eigen: stable 3.4.0 (bottled), HEAD

I believe I'm running v5.0.3 since it shows being built from the right commit despite showing v5.0.1.

@jbreue16
Copy link
Contributor

jbreue16 commented Jan 3, 2025

Thank you for reporting this.

I reproduced the issue but then started to think that this might not be a Bug: Recently, we have changed our release strategy to Gitlab Flow, which is briefly described in the developer documentation. To put it briefly, you've built the master branch of CADET, which is not the source of truth for version 5.0.3.
The source of truth for version 5.0.3 is the support branch v5.0.X.

However, building this branch still results in the same issue, which is definitely a Bug. There were some shenanigans with tagging one of our last releases, which might have caused this, but Ill have to return to this issue some other time.
@schmoelder @hannahlanzrath for your notice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants