Add option to use warning instead of critical

[LorenzBischof]

I think critical is the wrong severity, even for security updates. We have a nightly cronjob on our servers that runs yumcron. Critical should only be used for problems that directly affect a system and require immediate attention.

[calestyo]

I'm not sure whether this is the right approach.
If one just doesn't want to see "Critical" checks or don't consider security updates critical,… then don't run a test or simply disable notifications for it.

All checks typically take their respective "worst" case as critical, e.g. a check_smartstatus would likely give you "Critical" if the overall health status is "FAILING" and not just a "Warning" because some people may have e.g. a RAID in place and one failing disk wouldn't harm them.

The only case that I could at least think of where this would remotely make sense was:
If yum-security isn't in place (i.e. --all-updates is used) that it then gives Warning rather than Critical.
But conceptually even that doesn't make sense IMHO. If the plugin doesn't differentiate between security/non-security updates, than one must assume that there actually are security updates amongst.
That in case should make the status critical then.

[LorenzBischof]

I understand your view, but we have a dashboard that shows the amount of critical checks. What you say might work for other plugins like load or disk checks. It would be really nice to be able to choose the state. Would you accept a pull request?

[calestyo]

Uhm… if you would wait a bit,… I'm actually just in the process of re-implementing check_yum from scratch, to hopefully solve some longer standing issues.
I haven't pushed the new version yet, an it will probably still take some time to be finished, but it already includes code that allows setting the return states for different events.

[LorenzBischof]

very nice! thank you