Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollout C8 templates support #2731

Closed
Tracked by #2640
pinussilvestrus opened this issue Feb 7, 2022 · 1 comment · Fixed by #2785
Closed
Tracked by #2640

Rollout C8 templates support #2731

pinussilvestrus opened this issue Feb 7, 2022 · 1 comment · Fixed by #2785
Assignees

Comments

@pinussilvestrus
Copy link
Contributor

pinussilvestrus commented Feb 7, 2022

What should we do?

In order to make new C8 templates available, we have to add the cloud-element-templates provider to the Cloud Bpmn Editor (via camunda-bpmn-js). Since we have now two types of element templates, we need to make sure we only add correct element templates to the respective tab (C7 templates for platform, C8 templates for cloud, cf. bpmn-io/bpmn-js-properties-panel#561)

Components we need to touch

  • CloudBpmnEditor (load templates, distinguish with platform templates)
  • features/applyDefaultTemplates
  • ElementTemplatesModal (display for cloud as well)
  • CloudConnect Plugin (verify it does not explode)

Why should we do it?

Make C8 templates available.
Child of #2640

@pinussilvestrus pinussilvestrus self-assigned this Feb 10, 2022
@pinussilvestrus pinussilvestrus added the ready Ready to be worked on label Feb 17, 2022 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus removed the backlog Queued in backlog label Feb 17, 2022
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed ready Ready to be worked on labels Feb 17, 2022
@pinussilvestrus pinussilvestrus added ready Ready to be worked on and removed in progress Currently worked on labels Feb 17, 2022
@pinussilvestrus
Copy link
Contributor Author

ElementTemplatesModal (display for cloud as well)

I just noticed that the modal is built as a bpmn-js plugin, hooking into bpmn.modeler.configure and adding certain extensions.

So, adding this for cloud-bpmn is basically blocked by https://github.com/bpmn-io/internal-docs/issues/425, making it possible to hook into the same events for cloud tabs (/cc @Skaiir ).

image

@pinussilvestrus pinussilvestrus added the in progress Currently worked on label Feb 22, 2022 — with bpmn-io-tasks
@pinussilvestrus pinussilvestrus removed the ready Ready to be worked on label Feb 22, 2022
pinussilvestrus pushed a commit to camunda/camunda-bpmn-js that referenced this issue Feb 24, 2022
pinussilvestrus pushed a commit to camunda/camunda-bpmn-js that referenced this issue Feb 24, 2022
pinussilvestrus pushed a commit to camunda/camunda-bpmn-js that referenced this issue Feb 24, 2022
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Feb 25, 2022
pinussilvestrus pushed a commit that referenced this issue Feb 25, 2022
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant