Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FEEL editor Suggestions #3884

Closed
marstamm opened this issue Sep 25, 2023 · 3 comments · Fixed by #3959
Closed

Update FEEL editor Suggestions #3884

marstamm opened this issue Sep 25, 2023 · 3 comments · Fixed by #3959
Assignees
Milestone

Comments

@marstamm
Copy link
Member

What should we do?

the is defined() function: the behavior of the function will change with Camunda 8.3

The new version of the FEEL-Scala engine is much more null-friendly. Instead of failing the evaluation, for example, because of missing variables, it returns null. The new behavior is similar to the current behavior of the FEEL JS engine.
Because of the new behavior, the is defined() function is effectively just a null-check. I recommend to replace the usage of is defined(x) with x != null.

It should be marked as deprecated and removed from auto-completion

Why should we do it?

cf slack: https://camunda.slack.com/archives/CKGH9LR40/p1695628447744909?thread_ts=1695374400.947109&cid=CKGH9LR40

@marstamm
Copy link
Member Author

Suggestions are compiled from the platform docs, so changes/removal on the will be reflected once we run the script again.

https://github.com/bpmn-io/feel-editor/blob/main/scripts/compileBuiltins.js

I just noticed that it uses versioned docs instead of latest, this should be tackled in this issue as well

@barmac barmac added backlog Queued in backlog ready Ready to be worked on and removed backlog Queued in backlog labels Sep 26, 2023
@barmac
Copy link
Collaborator

barmac commented Sep 26, 2023

I'm moving this to ready, and let's discuss it later whether we want to prioritize this.

@CatalinaMoisuc CatalinaMoisuc added this to the M70 milestone Oct 17, 2023
@marstamm marstamm added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Oct 23, 2023
@marstamm
Copy link
Member Author

fixed upstream via bpmn-io/feel-editor#45

marstamm added a commit that referenced this issue Nov 2, 2023
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 2, 2023
marstamm added a commit that referenced this issue Nov 2, 2023
marstamm added a commit that referenced this issue Nov 6, 2023
nikku pushed a commit that referenced this issue Nov 6, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants