Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can attach link catch events to a task by copy-pasting #3967

Closed
hkupitz opened this issue Nov 7, 2023 · 3 comments · Fixed by #4009
Closed

Can attach link catch events to a task by copy-pasting #3967

hkupitz opened this issue Nov 7, 2023 · 3 comments · Fixed by #4009
Assignees
Labels
bug Something isn't working
Milestone

Comments

@hkupitz
Copy link
Contributor

hkupitz commented Nov 7, 2023

Describe the bug

It is possible to attach a link event to a task by copy-pasting it, effectively making it a boundary event which is not allowed according to the BPMN specification.

image

Modeler_Link_Boundary

Afterwards it becomes intertwined with the task and can only be detached by using the arrow keys.

Steps to reproduce

  1. Place a task on the canvas.
  2. Place an intermediate event on the canvas.
  3. Make it a link intermediate catch event.
  4. Copy it.
  5. Paste it.
  6. Attach it to the task.

Expected behavior

Link events should not be able to be attached to a task at all.

Environment

  • OS: Windows 10
  • Camunda Modeler Version: 5.16.0

Additional context

This does not work with [email protected], so it seems to be caused by something Modeler-specific.

@hkupitz hkupitz added the bug Something isn't working label Nov 7, 2023
@marstamm
Copy link
Member

I can reproduce this. Root cause is the rules for attach rules in camunda-bpmn-js, where we do not consider the spec:
https://github.com/camunda/camunda-bpmn-js/blob/847d4345b6380920c5d9e1fe510ffd50350ba70c/lib/camunda-cloud/features/rules/BpmnRules.js#L87-L90

Moving to ready

@marstamm marstamm added the ready Ready to be worked on label Nov 21, 2023
@philippfromme philippfromme self-assigned this Nov 28, 2023
@philippfromme
Copy link
Contributor

I found the original issue that led to the introduction of the current behavior: zeebe-io/zeebe-modeler#31. In the meantime the rules in bpmn-js have been adjusted as well (bpmn-io/bpmn-js#1041) to allow attaching intermediate catch events and replacing them with boundary events, so there is some duplication here. I think we should remove the custom attach rule from camunda-bpmn-js and adjust the rule in bpmn-js to allow attaching both intermediate catch and throw events.

@philippfromme philippfromme added in progress Currently worked on and removed ready Ready to be worked on labels Nov 28, 2023
philippfromme added a commit to camunda/camunda-bpmn-js that referenced this issue Nov 29, 2023
nikku pushed a commit to camunda/camunda-bpmn-js that referenced this issue Nov 29, 2023
@nikku
Copy link
Member

nikku commented Nov 29, 2023

Fixed upstream via camunda/camunda-bpmn-js#325.

@nikku nikku added this to the M71 milestone Nov 29, 2023
@nikku nikku added fixed upstream Requires integration of upstream change and removed in progress Currently worked on labels Nov 29, 2023
This was referenced Dec 5, 2023
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on needs review Review pending and removed fixed upstream Requires integration of upstream change in progress Currently worked on labels Dec 5, 2023
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants