Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DMN editor breaks when literal expression name is changed in the properties panel #4684

Closed
barmac opened this issue Nov 8, 2024 · 0 comments · Fixed by #4620
Closed

DMN editor breaks when literal expression name is changed in the properties panel #4684

barmac opened this issue Nov 8, 2024 · 0 comments · Fixed by #4620
Assignees
@barmac
Labels
bug Something isn't working DMN
Milestone
M83

Comments

@barmac
Copy link
Collaborator

barmac commented Nov 8, 2024

Describe the bug

Given I have a literal expression, when I change its name in the properties panel, the editor breaks so I cannot model anymore.

Steps to reproduce

Cf. bpmn-io/dmn-js-properties-panel#103

Expected behavior

Editor does not break.

Environment

  • OS: [e.g. MacOS 10.2, Windows 10]
  • Camunda Modeler Version: 5.29.0
  • Execution Platform: [e.g. Camunda 7, Camunda 8]
  • Installed plug-ins: [...]

Additional context

Related to bpmn-io/dmn-js-properties-panel#103
@barmac barmac added the bug Something isn't working label Nov 8, 2024
@barmac barmac self-assigned this Nov 8, 2024
@barmac barmac added ready Ready to be worked on DMN labels Nov 8, 2024
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac
fix: make name change behavior not break on name change
38b5c31 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684
@barmac barmac mentioned this issue Nov 8, 2024
Merged
4 tasks
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
4b4fd90 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
d01236b 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
ce75a55 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
barmac added a commit to bpmn-io/dmn-js that referenced this issue Nov 8, 2024
@barmac @nikku
fix: make name change behavior not break on name change
5a5b682 
Related to bpmn-io/dmn-js-properties-panel#103
Related to camunda/camunda-modeler#4684

Co-authored-by: Nico Rehwaldt <[email protected]>
@barmac barmac added fixed upstream Requires integration of upstream change and removed ready Ready to be worked on labels Nov 8, 2024
nikku added a commit that referenced this issue Nov 20, 2024
@nikku
deps: bump to [email protected] / [email protected] / [email protected]
7b129b8 
  Closes #4684

deps: bump [email protected] and [email protected]
@nikku nikku mentioned this issue Nov 20, 2024
Merged
17 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Nov 20, 2024
@nikku nikku added this to the M83 milestone Nov 21, 2024
@nikku nikku closed this as completed in 1ebd413 Nov 21, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@barmac barmac

Labels
bug Something isn't working DMN
Projects
None yet
Milestone
M83
2 participants
@nikku @barmac