From 9fb84484b0ac20a76e42f19e039166e26b682037 Mon Sep 17 00:00:00 2001
From: Mathias Vandaele <mathias.vandaele@camunda.com>
Date: Wed, 11 Dec 2024 12:33:17 +0100
Subject: [PATCH] feature(s3-connector): minor corrections

---
 .../element-templates/aws-s3-outbound-connector.json  | 11 +++++------
 .../hybrid/aws-s3-outbound-connector-hybrid.json      | 11 +++++------
 .../camunda/connector/aws/s3/S3ConnectorFunction.java |  3 ++-
 .../io/camunda/connector/aws/s3/core/S3Executor.java  |  2 +-
 4 files changed, 13 insertions(+), 14 deletions(-)

diff --git a/connectors/aws/aws-s3/element-templates/aws-s3-outbound-connector.json b/connectors/aws/aws-s3/element-templates/aws-s3-outbound-connector.json
index aa48e9f275..1c2e0b02fa 100644
--- a/connectors/aws/aws-s3/element-templates/aws-s3-outbound-connector.json
+++ b/connectors/aws/aws-s3/element-templates/aws-s3-outbound-connector.json
@@ -3,7 +3,7 @@
   "name" : "AWS S3 Outbound Connector",
   "id" : "io.camunda.connectors.aws.s3.v1",
   "description" : "Execute S3 requests",
-  "documentationRef" : "https://docs.camunda.io/docs/",
+  "documentationRef" : "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/aws-s3/",
   "version" : 1,
   "category" : {
     "id" : "connectors",
@@ -216,6 +216,9 @@
     "id" : "uploadActionKey",
     "label" : "AWS key",
     "optional" : true,
+    "constraints" : {
+      "notEmpty" : true
+    },
     "feel" : "optional",
     "group" : "uploadObject",
     "binding" : {
@@ -291,9 +294,6 @@
     "label" : "Create document",
     "optional" : false,
     "value" : true,
-    "constraints" : {
-      "notEmpty" : true
-    },
     "feel" : "optional",
     "group" : "downloadObject",
     "binding" : {
@@ -305,7 +305,7 @@
       "equals" : "downloadObject",
       "type" : "simple"
     },
-    "tooltip" : "....",
+    "tooltip" : "If set to true, a document reference will be created. If set to false, the content will be extracted and provided inside the response.",
     "type" : "Boolean"
   }, {
     "id" : "resultVariable",
@@ -356,7 +356,6 @@
     "label" : "Retry backoff",
     "description" : "ISO-8601 duration to wait between retries",
     "value" : "PT0S",
-    "feel" : "optional",
     "group" : "retries",
     "binding" : {
       "key" : "retryBackoff",
diff --git a/connectors/aws/aws-s3/element-templates/hybrid/aws-s3-outbound-connector-hybrid.json b/connectors/aws/aws-s3/element-templates/hybrid/aws-s3-outbound-connector-hybrid.json
index e23e6620e8..a33b5ab9d7 100644
--- a/connectors/aws/aws-s3/element-templates/hybrid/aws-s3-outbound-connector-hybrid.json
+++ b/connectors/aws/aws-s3/element-templates/hybrid/aws-s3-outbound-connector-hybrid.json
@@ -3,7 +3,7 @@
   "name" : "Hybrid AWS S3 Outbound Connector",
   "id" : "io.camunda.connectors.aws.s3.v1-hybrid",
   "description" : "Execute S3 requests",
-  "documentationRef" : "https://docs.camunda.io/docs/",
+  "documentationRef" : "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/aws-s3/",
   "version" : 1,
   "category" : {
     "id" : "connectors",
@@ -221,6 +221,9 @@
     "id" : "uploadActionKey",
     "label" : "AWS key",
     "optional" : true,
+    "constraints" : {
+      "notEmpty" : true
+    },
     "feel" : "optional",
     "group" : "uploadObject",
     "binding" : {
@@ -296,9 +299,6 @@
     "label" : "Create document",
     "optional" : false,
     "value" : true,
-    "constraints" : {
-      "notEmpty" : true
-    },
     "feel" : "optional",
     "group" : "downloadObject",
     "binding" : {
@@ -310,7 +310,7 @@
       "equals" : "downloadObject",
       "type" : "simple"
     },
-    "tooltip" : "....",
+    "tooltip" : "If set to true, a document reference will be created. If set to false, the content will be extracted and provided inside the response.",
     "type" : "Boolean"
   }, {
     "id" : "resultVariable",
@@ -361,7 +361,6 @@
     "label" : "Retry backoff",
     "description" : "ISO-8601 duration to wait between retries",
     "value" : "PT0S",
-    "feel" : "optional",
     "group" : "retries",
     "binding" : {
       "key" : "retryBackoff",
diff --git a/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/S3ConnectorFunction.java b/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/S3ConnectorFunction.java
index 1555881850..0ec57a3538 100644
--- a/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/S3ConnectorFunction.java
+++ b/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/S3ConnectorFunction.java
@@ -34,7 +34,8 @@
       @ElementTemplate.PropertyGroup(id = "uploadObject", label = "Upload an object"),
       @ElementTemplate.PropertyGroup(id = "downloadObject", label = "Download an object"),
     },
-    documentationRef = "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/aws-s3/",
+    documentationRef =
+        "https://docs.camunda.io/docs/components/connectors/out-of-the-box-connectors/aws-s3/",
     icon = "icon.svg")
 public class S3ConnectorFunction implements OutboundConnectorFunction {
 
diff --git a/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/core/S3Executor.java b/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/core/S3Executor.java
index 18b56a0721..6e554402c4 100644
--- a/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/core/S3Executor.java
+++ b/connectors/aws/aws-s3/src/main/java/io/camunda/connector/aws/s3/core/S3Executor.java
@@ -42,7 +42,7 @@ public S3Executor(S3Client s3Client, Function<DocumentCreationRequest, Document>
   }
 
   public static S3Executor create(
-          S3Request s3Request, Function<DocumentCreationRequest, Document> createDocument) {
+      S3Request s3Request, Function<DocumentCreationRequest, Document> createDocument) {
     return new S3Executor(
         S3Client.builder()
             .credentialsProvider(CredentialsProviderSupportV2.credentialsProvider(s3Request))