Broken GitHub contributor link in footer

[medubelko]

Due to improper string composition in the footer, the Edit this page on GitHub link has a malformed path.

canonical-sphinx/canonical_sphinx/theme/templates/footer.html

Line 124 in c7149c3

<a class="muted-link" href="{{ github_url }}/edit/{{ github_version }}{{ github_folder }}{{ pagename }}{{ page_source_suffix }}">Edit this page on GitHub</a>

All the Starcraft repos have this problem. Example: https://documentation.ubuntu.com/rockcraft/en/stable/

Originally reported in canonical/rockcraft#705

[SecondSkoll]

I believe you need to add an entry to the HTML context, otherwise the github_version will be the commit and not the branch. It should be something like:

'github_version': 'main',

[medubelko]

That results in https://github.com/canonical/rockcraft/edit/maindocsindex.rst. In either case there are missing slashes, hence my suggestion that it was a string composition issue.

It looks like this might only affect Starcraft repos; Anbox Cloud doesn't have this problem. At that, it might be because it's inheriting from an old version of the starter pack, not the extension. I'll report back once my team has rebased their docs.

[SecondSkoll]

Strange, from the history there's no change between the 0.1.0 version and now.