Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if generate_test_config failed, wifi_client_test_netplan.py won't restore config file #1674

Open
1 task done
hanhsuan opened this issue Dec 25, 2024 · 1 comment
Open
1 task done
Labels
bug Something isn't working Critical

Comments

@hanhsuan
Copy link
Contributor

hanhsuan commented Dec 25, 2024

Bug Description

The generate_test_config will raise SystemExit while missing ssid. Then the main will stop without restoring config.

This will remove files under /etc/netplan, /lib/netplan, /run/netplan that defined in here then make the debsum check fail.

Cert-blocker Test Case

  • cert-blocker

To Reproduce

  1. run wifi test without setting SSID

Expected Result

It should restore all config files while executing the script failed.

Actual Result

script won't restore config file if generate_test_config failed.

Environment

  • OS: ubuntu 24.04
  • checkbox type: debian
  • checkbox version: 4.3.0.dev36

Relevant log output

Interface wlp0s20f3 using module iwlwifi
  Parameters:
    11n_disable: 0
    power_save: N
    swcrypto: 0
    power_level: 0
    amsdu_size: 0
    uapsd_disable: 3
    fw_restart: Y
    disable_11be: N
    led_mode: 0
    disable_11ax: N
    enable_ini: 16
    disable_11ac: N
    bt_coex_active: Y
    remove_when_gone: N
    nvm_file: (null)

Checking kernel ring buffer for iwlwifi messages:


## Backup any existing netplan configuration files

## Delete any existing netplan configuration files

## Generate a test netplan configuration
A SSID is required for the test

Additional context

No response

@hanhsuan hanhsuan added the bug Something isn't working label Dec 25, 2024
Copy link

Thank you for reporting your feedback to us!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CHECKBOX-1718.

This message was autogenerated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Critical
Projects
None yet
Development

No branches or pull requests

2 participants