chore: support multiple charm bases #272
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We add support for building, running integration tests, and publishing for multiple charm bases. For now, we will support
[email protected]
and[email protected]
.Fixes #270
This is a temporary solution
This solution is aimed at supporting the Openstack team in releasing sunbeam by christmas. In the longer run, we'll want to leverage the (not yet existing) multi base support in charmcraft.
Why aren't we building for [email protected] on arm?
There is an issue when installing tox on Ubuntu24.04 on the arm runner:
Arm support is a nice to have (that nobody uses for the time being) and solving this issue can be done at a different time.
Rationale
As of the latest charmcraft version, we can only specify 1 base per
charmcraft.yaml
file.Reference:
Other alternatives
We could have gone with other alternatives like different charm folders, branches, or scripts. I found this approach here (2 different charmcraft.yaml) files to be the simplest.
Checklist: