Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Option to Configure Animation Style in PhotoViewer #72

Open
jackdwo opened this issue Sep 16, 2024 · 5 comments
Open

Add Option to Configure Animation Style in PhotoViewer #72

jackdwo opened this issue Sep 16, 2024 · 5 comments

Comments

@jackdwo
Copy link

jackdwo commented Sep 16, 2024

The current closing animation of the PhotoViewer is weird and inconsistent with standard modal view animations on mobile devices, resulting in a disjointed user experience. Adding an option to configure the animation style in the PhotoViewer’s settings would allow developers to customize both the opening and closing animations to better align with native modal animations, providing a more cohesive experience.

@bazuka5801
Copy link

I also use this plugin in real projects and know about the different user experience ))
@jackdwo What animation do you suggest to be the default?

@jackdwo
Copy link
Author

jackdwo commented Sep 16, 2024

I hope the default modal view opening and closing animation to be a slide up/down transition like iOS. @bazuka5801

@JulienLecoq
Copy link

@jackdwo I agree, the closing animation is weird.

@anthonyplews
Copy link

Agree closing animation is weird, it should rather animate back down than to the side. Maybe better to add an option for close direction.

@skle
Copy link

skle commented Jan 31, 2025

My solution is to edit

photoviewer/ios/Plugin/Extensions/UIViewController.swift

and change transition.type = CATransitionType.push to transition.type = CATransitionType.reveal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants