Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with nameless active tab #42

Open
raboczky-david opened this issue Jan 24, 2019 · 4 comments
Open

Doesn't work with nameless active tab #42

raboczky-david opened this issue Jan 24, 2019 · 4 comments

Comments

@raboczky-david
Copy link

raboczky-david commented Jan 24, 2019

If the pattern includes tab name like "n|t", and the active tab doesn't have name, so FF writes the URL on the tab and "Mozilla Firefox" in the window title. Then the Crappy Firetitle doesn't work, even if the pattern contains custom window name and a window name is given, the displayed name remains "Mozilla Firefox".

@judgej
Copy link

judgej commented Apr 18, 2019

I've just put my finger on this problem too. The names have been driving me mad, sometimes appearing to work and sometimes not, and I could not work out why, assuming it to be random.

But it's not. It's windows with a current tab not having a title attribute. That happens a lot when developing code, with pages just splurting out bunch of text and no formal HTML page.

@raboczky-david
Copy link
Author

Hey @judgej, thanks for caring this issue! Can you handle the case, when the original page doesn't have a name, but the pattern has other parts, what could be displayed?

@judgej
Copy link

judgej commented Apr 30, 2019

I just get "Mozilla Firefox" as the name of the window, no matter what else is in the title pattern. For example, I do not see the "xxxx":

n[tabs:]T xxxx

@raboczky-david
Copy link
Author

Yes, that's my problem too. Even if the pattern has static part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants