typo?

[abcoxyzide]

CNAqc/R/peak_detector.R

Lines 101 to 110 in 61fab68

	# Handle special case where everything is discarded by including the one
	# with highest value of counts_per_bin (just that).
	if (all(xy_peaks$discarded)) {
	xy_peaks = xy_peaks %>%
	mutate(discarded = ifelse(
	counts_per_bin == max(xy_peaks$counts_per_bin),
	TRUE,
	discarded
	))
	}

line 107 should be FALSE instead of TRUE, because you want to keep the max count bin?

[caravagn]

I think so, will check it asap.

[Militeee]

Yea had a look at it, probably a typo, this does not update discarded so all(xy_peaks$discarded) stays TRUE.
Fixed thanks for spotting.
Pretty degenerate case though, might think about returning an error (or a worning) anyway.