Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning message after changing min_absolute_karyotype_mutations #36

Closed
mkyriak opened this issue Apr 15, 2024 · 6 comments
Closed

Warning message after changing min_absolute_karyotype_mutations #36

mkyriak opened this issue Apr 15, 2024 · 6 comments
Assignees
Labels
help wanted Extra attention is needed

Comments

@mkyriak
Copy link

mkyriak commented Apr 15, 2024

Hello,

Thank you for the tool. Finally, there is a way to start from SNVs, CNAs and purity and perform QC and check for clonality!

I tried to run analyze_peaks command by changing the min_absolute_karyotype_mutations parameter since I want to perform the analysis on targeted sequencing data and not on WGS.

This is an instance of the commands I tried (after running init).

samplePurityTolerance <- auto_tolerance(0.6, 40, fpr=0.1)

sample_analysis <- analyze_peaks(sample_analysis, karyotypes = c("1:0", "1:1", "2:0", "2:1"), purity_error = samplePurityTolerance$epsilon_range, min_absolute_karyotype_mutations=20)

However, when I enter a number that is smaller than the total number of SNVs that I detect in my sample, I get the following error:

Warning messages:
1: In `[<-.data.frame`(`*tmp*`, ri, , value = list(Purity = 0.02,  :
  provided 2 variables to replace 1 variables
2: In `[<-.data.frame`(`*tmp*`, ri, , value = list(Purity = 0.014,  :
  provided 2 variables to replace 1 variables
3: In `[<-.data.frame`(`*tmp*`, ri, , value = list(Purity = 0.009,  :
  provided 2 variables to replace 1 variables

I am not sure what is going on here, could you please help me figure it out?

Thank you in advance!

Maria

@caravagn
Copy link
Collaborator

Hi, warnings are not errors. Did it compute anything?

@caravagn caravagn added the help wanted Extra attention is needed label Apr 19, 2024
@mkyriak
Copy link
Author

mkyriak commented May 15, 2024

Hello @caravagn, I am sorry I missed the notification. No, it didn't compute anything.

My samples are very heterogeneous and I was trying to play around with min_absolute_karyotype_mutations but every time I was entering a number smaller than the total number of SNVs, it was giving me this error. Though I am not sure how this impacts the calculation.

Thank you!

@caravagn
Copy link
Collaborator

@AliceAntonello can you raise a stop() error when this happens?

@AliceAntonello
Copy link
Contributor

Sure

@caravagn
Copy link
Collaborator

@AliceAntonello if you pushed the fix can u close this?

@AliceAntonello
Copy link
Contributor

I tried to reproduce the problem but I didn't receive any error and the computations went smoothly. Also, a check on the minimum number of mutations per karyotype is already in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants