Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cardano-node 8 #1007

Closed
4 tasks done
ch1bo opened this issue Jul 31, 2023 · 1 comment · Fixed by #1015
Closed
4 tasks done

Upgrade to cardano-node 8 #1007

ch1bo opened this issue Jul 31, 2023 · 1 comment · Fixed by #1015
Labels
task Subtask of a bigger feature.
Milestone

Comments

@ch1bo
Copy link
Member

ch1bo commented Jul 31, 2023

Why

We are still using cardano node 1.35.7 while there had been newer, mainnet compatible node releases.

Upgrading to cardano-node 8.x is desirable as it allows integration with Mithril to bootstrap a cardano-node.

What

  • At least one cardano-node 8.x version is supported by the hydra-node
    • The one or multiple kown-to-work versions is added to the changelog
  • A breaking change of Hydra scripts is acceptable
  • JSON encoding of objects on the Hydra API may have breaking changes
    • e.g. due to transitive cardano-ledger update
    • All API changes are documented
    • When changed, the cardanonical JSON schema shall be used as new reference
  • Determine and clarify whether the overall Tx CBOR has changed in a non-backward compatible way, i.e. can previously working transaction cbors still be sent through NewTx

How

https://github.com/input-output-hk/hydra/tree/ch1bo/use-cardano-node-8

https://github.com/input-output-hk/hydra/tree/ch1bo/update-dependencies

When updating to 8.1.2 while keeping the same (cardano-api 1.35.0-rc4) we had problems:

  • The api tries NodeToClientV_15 which seems to have been broken (but was never released). Querying the tip (which uses chain sync) errors.
  • When overriding to use NodeToClientV_14, the chain sync works, but the local state query results in errors:
MuxError MuxBearerClosed "<socket: 40> closed when reading data, waiting on next header True"

Asked for more information on the NodeToClient API situation in slack.

Might need to bite the bullet of upgrading cardano-api and with that cardano-ledger throughout the repo instead..


Maybe have a collaboratively maintained json instance repository with ogmios: https://github.com/CardanoSolutions/cardanonical

https://github.com/CardanoSolutions/cardanonical/blob/main/cardano.json holds a quite complete json schema with all kinds of Cardano entities (as used by ogmios 6)

@ch1bo ch1bo added the task Subtask of a bigger feature. label Jul 31, 2023
@ch1bo ch1bo added this to the 0.12.0 milestone Jul 31, 2023
@ch1bo ch1bo self-assigned this Aug 2, 2023
@ch1bo
Copy link
Member Author

ch1bo commented Aug 7, 2023

We ran into this problem: IntersectMBO/plutus#5460

@ffakenz ffakenz assigned v0d1ch and unassigned ch1bo Aug 9, 2023
@v0d1ch v0d1ch mentioned this issue Aug 9, 2023
4 tasks
@ch1bo ch1bo self-assigned this Aug 10, 2023
@ch1bo ch1bo linked a pull request Aug 10, 2023 that will close this issue
4 tasks
@ch1bo ch1bo unassigned v0d1ch and ch1bo Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Subtask of a bigger feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants