--strategies on CLI do not seem to override disabled-strategies in the manifest

[ilyagr]

We discussed in #1830 (comment) that they are supposed to.

I might be missing something, but the code didn't seem to do that. I then added the following to strategies.sh, and the test seems to fail.

(The diff also fixes a comment) (Update: I made a draft PR for this diff, because why not. #1852)

diff --git a/e2e-tests/strategies.sh b/e2e-tests/strategies.sh
index 0248d6c378..7708afc852 100755
--- a/e2e-tests/strategies.sh
+++ b/e2e-tests/strategies.sh
@@ -37,7 +37,7 @@
 ## Test compile-only strategy
 "./$1" binstall --no-confirm --strategies compile [email protected]
 
-## Test --disable-strategies
+## Test `disabled-strategies=["compile", "quick-install"]` in Cargo.toml
 set +e
 
 "./$1" binstall --no-confirm --manifest-path "manifests/strategies-test-Cargo.toml" [email protected]
@@ -49,3 +49,6 @@
     echo "Expected exit code 94, but actual exit code $exit_code"
     exit 1
 fi
+
+## Test --strategies overriding `disabled-strategies=["compile"]` in Cargo.toml
+"./$1" binstall --no-confirm --manifest-path "manifests/strategies-test-Cargo.toml" --strategies compile [email protected]

The last lines of the test were:

+ ./cargo-binstall binstall --no-confirm --manifest-path manifests/strategies-test-Cargo.toml --strategies compile [email protected]
 INFO resolve: Resolving package: 'cargo-update@=11.1.2'
ERROR Fatal error:
  × For crate cargo-update: Fallback to cargo-install is disabled
  ╰─▶ Fallback to cargo-install is disabled

error: Recipe `e2e-test` failed on line 234 with exit code 94

(I came up upon this as I was thinking about adding some more user-facing messaging about the strategy being disabled by the maintainer)

---

Another aside: how is one supposed to run tests? I had to cargo build and then symlink target/debug to target/aarch64-apple-darwin/debug before just e2e-test-strategies worked. I'm guessing there's a better way?

[NobodyXu]

how is one supposed to run tests?

just build
just e2e-tests

In justfile, we also provide a target for each target, so you can run it after just build

[NobodyXu]

cargo-binstall/crates/bin/src/entry.rs

Line 88 in f2a184d

disabled_strategies: None,

It turns out I forgot to forward it to resolve, which passes an iterator of cli_overrides, target_meta overrides to

cargo-binstall/crates/binstalk-types/src/cargo_toml_binstall.rs

Line 100 in f2a184d

pub fn merge_overrides<'a, It>(&self, pkg_overrides: It) -> Self

Since I set it to None it fallbacks to target_meta (e.g. package.binstall.x86_64_...) then the one found in package.binstall