Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting custom parameters to null vs empty is confusing #143

Open
mpawliszyn opened this issue Oct 21, 2020 · 2 comments
Open

Setting custom parameters to null vs empty is confusing #143

mpawliszyn opened this issue Oct 21, 2020 · 2 comments

Comments

@mpawliszyn
Copy link
Collaborator

If a value is ever touched it will use empty string rather than null as the value. There is no way to unset it afaik either.

Not quite sure what we should do here. We could have a null checkbox that starts out checked. But that seems like overkill.

Another option is to treat empty as null but this isn't great either. Maybe someone else has a better idea.

@shellderp
Copy link
Collaborator

oh yeah... I ran into this before. it is tricky..

the only other idea I had was to have only nonnullable parameter boxes visible at the start (we'd need to add a "required" flag ..) and a "add" button to add nullable parameters, that would add the input field and a blank one would be emptystring, to null it out you just click x to remove it

I'm ok with a null checkbox too

@mpawliszyn
Copy link
Collaborator Author

I sort-of like the idea of telling Backfila when a parameter is required. Although having something be required and then accepting empty string might not be enough to fix confusion? Maybe it is.

I guess that add button would contain the remaining set of parameters.

All this UI dev, not sure my brain can handle it anymore 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants