Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] P2PK does not support SIG_ALL #186

Open
lescuer97 opened this issue Jun 14, 2024 · 3 comments · Fixed by cashubtc/cashu-crypto-ts#4
Open

[Bug] P2PK does not support SIG_ALL #186

lescuer97 opened this issue Jun 14, 2024 · 3 comments · Fixed by cashubtc/cashu-crypto-ts#4
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lescuer97
Copy link

if I Create a token with nutstash that is P2PK. It will have SIG_ALL signaled in the inputs.

At this moment the wallet is not signing the outputs and making the swap fail.
image

@callebtc callebtc changed the title blindMessage not being signed [Bug] P2PK does not support SIG_ALL Jun 26, 2024
@callebtc callebtc added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Jun 26, 2024
@lollerfirst
Copy link
Contributor

lollerfirst commented Aug 16, 2024

@lescuer97 If I understand this correctly, the issue here arises when trying to redeem a token with 'SIG_ALL' proofs.
It seems to me that the problem is in cashu-ts, precisely here: createSwapPayload.
It signs the inputs, but does not verify SIG_ALL conditions. I'll open a PR for it if someone isn't already fixing this.

@lescuer97
Copy link
Author

@lescuer97 If I understand this correctly, the issue here arises when trying to redeem a token with 'SIG_ALL' proofs. It seems to me that the problem is in cashu-ts, precisely here: createSwapPayload. It signs the inputs, but does not verify SIG_ALL conditions. I'll open a PR for it if someone isn't already fixing this.

I'm pretty sure they are correlated because cashu.me is using cashu-ts behind the scenes.

I don't think anyone is working on that right now so I think you are free to do it.

@prusnak
Copy link
Contributor

prusnak commented Jan 2, 2025

@lescuer97 can you confirm that the issue has been fixed and deployed to production?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants