Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block page reloads when the global mutex is triggered #236

Open
callebtc opened this issue Sep 11, 2024 · 2 comments · May be fixed by #321
Open

Block page reloads when the global mutex is triggered #236

callebtc opened this issue Sep 11, 2024 · 2 comments · May be fixed by #321
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@callebtc
Copy link
Collaborator

The global mutex is defined in the uiStore (ui.ts).

Resources:
https://stackoverflow.com/questions/52342200/how-to-prevent-pull-to-refresh-in-pwa-progressive-web-apps
https://stackoverflow.com/questions/69261011/disable-pull-to-refresh-in-ios-15-safari#69589919

@callebtc callebtc added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Sep 11, 2024
@novascreen
Copy link

Hi @callebtc
i'm trying to get my feet wet in this repo and looked at this issue.

Do you still want this to only happen when the mutex is locked? It looks like you added CSS to prevent pull-to-refresh at all times for Android/Chrome here

There seems to be a quick way to expand this to Safari by applying this:

html, body {
  overscroll-behavior: none;
}

(Sources: https://stackoverflow.com/a/78711166, https://www.matuzo.at/blog/2022/100daysof-day53)

Happy to make a PR for this change or make it conditional on when the mutex is locked.

@callebtc
Copy link
Collaborator Author

Hi @callebtc
i'm trying to get my feet wet in this repo and looked at this issue.

Do you still want this to only happen when the mutex is locked? It looks like you added CSS to prevent pull-to-refresh at all times for Android/Chrome here

There seems to be a quick way to expand this to Safari by applying this:

html, body {
  overscroll-behavior: none;
}

(Sources: https://stackoverflow.com/a/78711166, https://www.matuzo.at/blog/2022/100daysof-day53)

Happy to make a PR for this change or make it conditional on when the mutex is locked.

Hi! I think it could make sense to prevent reloads always since we have a reload button in the top right of the app. Let's try it?

@novascreen novascreen linked a pull request Jan 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants