Wallet: determine valid amounts from mint's keys response #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update `mint` method to use allowed amounts from the mint - Add `get_allowed_amounts` method to fetch supported denominations - Modify `test_mint_amounts_wrong_order` to expect new error message
callebtc
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
keysresponse #618Changes Made
mintmethod in theWalletclass to use allowed amounts from the mint instead of hardcoding 2^n denominations.get_allowed_amountsmethod to fetch supported denominations from the current keyset.test_mint_amounts_wrong_ordertest to expect the new error message for unsupported denominations.Background Context
The previous implementation assumed that mints would always use powers of 2 for token denominations. However, the Cashu protocol allows mints to use any denomination structure they prefer. This change makes the wallet more flexible and compliant with the protocol, enabling it to work with a wider range of mint configurations.
Testing
The existing test suite has been updated to reflect these changes. The
test_mint_amounts_wrong_ordertest now checks for the correct error message when attempting to mint unsupported denominations.