Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant JobType enum #51

Open
abyrd opened this issue Oct 11, 2017 · 1 comment
Open

Redundant JobType enum #51

abyrd opened this issue Oct 11, 2017 · 1 comment
Assignees

Comments

@abyrd
Copy link

abyrd commented Oct 11, 2017

In the MonitorableJob class we have an enum listing the types of monitorable jobs. However monitorable jobs are all represented by subclasses of the MonitorableJob class. This enum is redundant. Each subclass should either override a function returning a unique string, or (perhaps better) the shared superclass should just define a public function returning the simple class name so it's visible when the instances are serialized to JSON.

@abyrd abyrd self-assigned this Oct 11, 2017
@landonreed
Copy link
Member

landonreed commented Nov 13, 2018

Any such change on the server would need to be accompanied by a corresponding UI fix to the check for this value in this switch statement:

https://github.com/catalogueglobal/datatools-ui/blob/42211585c070484fe57ce188c2f0049378486cb7/lib/manager/actions/status.js#L123-L180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants