From 0ec4cd8ccf69c8e5b38ec3e5ec63c446460edf6a Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Tue, 7 Jan 2025 19:31:22 +0000 Subject: [PATCH 1/3] Add test --- reports/performance/_outliers.qmd | 29 +++++++++++++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/reports/performance/_outliers.qmd b/reports/performance/_outliers.qmd index 2332dd4..6993815 100644 --- a/reports/performance/_outliers.qmd +++ b/reports/performance/_outliers.qmd @@ -477,3 +477,32 @@ outlier_decile_breakout(training_data, 1) ``` ::: + +## Possible Output Errors + +::: panel-tabset + +### Card Level +```{r _outliers_output_errors_card} +assessment_card %>% + summarize( + "NA Card FMV" = sum(is.na(pred_card_initial_fmv)), + "Negative Card FMV" = sum(pred_card_initial_fmv < 0, na.rm = TRUE) + ) %>% + datatable() +``` + +### Pin Level +```{r _outliers_output_errors_pin} +assessment_pin %>% + summarize( + "NA Pin FMV" = sum(is.na(pred_pin_final_fmv)), + "Negative Pin FMV" = sum(pred_pin_final_fmv < 0, na.rm = TRUE), + "NA Building FMV" = sum(is.na(pred_pin_final_fmv_bldg)), + "Negative Building FMV" = sum(pred_pin_final_fmv_bldg < 0, na.rm = TRUE), + "NA Land FMV" = sum(is.na(pred_pin_final_fmv_land)), + "Negative Land FMV" = sum(pred_pin_final_fmv_land < 0, na.rm = TRUE) + ) %>% + datatable() +``` +::: From e5a3cdfe5f95ac9ea419e171d5a3da0993775be0 Mon Sep 17 00:00:00 2001 From: Damonamajor <56321109+Damonamajor@users.noreply.github.com> Date: Wed, 8 Jan 2025 10:36:24 -0600 Subject: [PATCH 2/3] Update reports/performance/_outliers.qmd Co-authored-by: Dan Snow <31494343+dfsnow@users.noreply.github.com> --- reports/performance/_outliers.qmd | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/reports/performance/_outliers.qmd b/reports/performance/_outliers.qmd index 6993815..146740d 100644 --- a/reports/performance/_outliers.qmd +++ b/reports/performance/_outliers.qmd @@ -483,6 +483,7 @@ outlier_decile_breakout(training_data, 1) ::: panel-tabset ### Card Level + ```{r _outliers_output_errors_card} assessment_card %>% summarize( @@ -490,19 +491,4 @@ assessment_card %>% "Negative Card FMV" = sum(pred_card_initial_fmv < 0, na.rm = TRUE) ) %>% datatable() -``` - -### Pin Level -```{r _outliers_output_errors_pin} -assessment_pin %>% - summarize( - "NA Pin FMV" = sum(is.na(pred_pin_final_fmv)), - "Negative Pin FMV" = sum(pred_pin_final_fmv < 0, na.rm = TRUE), - "NA Building FMV" = sum(is.na(pred_pin_final_fmv_bldg)), - "Negative Building FMV" = sum(pred_pin_final_fmv_bldg < 0, na.rm = TRUE), - "NA Land FMV" = sum(is.na(pred_pin_final_fmv_land)), - "Negative Land FMV" = sum(pred_pin_final_fmv_land < 0, na.rm = TRUE) - ) %>% - datatable() -``` ::: From 9400f93ca11dc552718ec732c0531adc22f7c0a4 Mon Sep 17 00:00:00 2001 From: Damonamajor Date: Wed, 8 Jan 2025 16:42:07 +0000 Subject: [PATCH 3/3] lintr --- reports/performance/_outliers.qmd | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/reports/performance/_outliers.qmd b/reports/performance/_outliers.qmd index 146740d..9731a44 100644 --- a/reports/performance/_outliers.qmd +++ b/reports/performance/_outliers.qmd @@ -491,4 +491,21 @@ assessment_card %>% "Negative Card FMV" = sum(pred_card_initial_fmv < 0, na.rm = TRUE) ) %>% datatable() +``` + +### Pin Level + +```{r _outliers_output_errors_pin} +assessment_pin %>% + summarize( + "NA Pin FMV" = sum(is.na(pred_pin_final_fmv)), + "Negative Pin FMV" = sum(pred_pin_final_fmv < 0, na.rm = TRUE), + "NA Building FMV" = sum(is.na(pred_pin_final_fmv_bldg)), + "Negative Building FMV" = sum(pred_pin_final_fmv_bldg < 0, na.rm = TRUE), + "NA Land FMV" = sum(is.na(pred_pin_final_fmv_land)), + "Negative Land FMV" = sum(pred_pin_final_fmv_land < 0, na.rm = TRUE) + ) %>% + datatable() +``` + :::