Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect tags applied to package #901

Open
kichik opened this issue May 21, 2022 · 3 comments
Open

Incorrect tags applied to package #901

kichik opened this issue May 21, 2022 · 3 comments
Labels
bug Something isn't working effort/medium About 3 days p2

Comments

@kichik
Copy link

kichik commented May 21, 2022

What is the URL of the page with the issue?

https://constructs.dev/packages/@cloudsnorkel/cdk-github-runners/v/0.0.11?lang=typescript

What did you do?

I created a package with specific keywords and a readme that mentions others.

What did you expect to happen?

I expected only my keywords to be used as tags.

What actually happened?

My keywords were used as tags, but also keywords automatically found in README.md. Specifically it found Kubernetes because I mentioned another package that provides the same solution but for Kubernetes. My package doesn't use Kubernetes. It also found MySQL from the sample code even though the package doesn't have much to do with MySQL.

Web Browser

Chrome

OS

No response

Other information

No response

@kichik kichik added the bug Something isn't working label May 21, 2022
@Chriscbr
Copy link
Contributor

So it turns out this bug is... sort of intended behavior at the moment. 😅 Automatically tagging packages based on the README is something we did to improve the visibility of packages when we launched Construct Hub, since many authors didn't add tags themselves. But as you point out, this has a lot of false positives. I think we can definitely look into tweaking these rules to be a bit less sensitive.

In the future these extra tags might become unnecessary once we have a way to search packages using a proper search index (e.g. OpenSearch).

@Chriscbr Chriscbr added the p2 label May 25, 2022
@kichik
Copy link
Author

kichik commented May 30, 2022

Makes total sense. The categorization does help constructs hub. Maybe we can have a special tag or other way to prevent this? A special comment line in the readme?

@Chriscbr
Copy link
Contributor

Yep - it's definitely possible to add some functionality that disables this behavior by adding a custom tag to the package, like construct-hub/do-not-autotag (and we'd probably want to hide this meta-tag on the front-end too). PRs are welcome.

@ryparker ryparker added the effort/medium About 3 days label Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working effort/medium About 3 days p2
Projects
None yet
Development

No branches or pull requests

3 participants