Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen option can be in conflict with user settings #214

Open
JulienPeloton opened this issue Dec 23, 2024 · 1 comment
Open

Fullscreen option can be in conflict with user settings #214

JulienPeloton opened this issue Dec 23, 2024 · 1 comment

Comments

@JulienPeloton
Copy link

Hello,

Starting from v3.3.0, the FullScreenActionButton sets the property zIndex to 1 in full screen, and de-reference it otherwise.

If Aladin Lite is embedded in an application that uses a different zIndex logic to position some of the elements above others (such as a navbar), this results of the Aladin fullscreen being below some elements... :-(

I propose to remove explicitly the lines 63 and 78 and let the user sets its own value for aladin.aladinDiv.style.zIndex if need be (tested successfully locally with versions 3.3.0 and 3.4.5).

@tboch
Copy link
Collaborator

tboch commented Jan 6, 2025

@bmatthieu3 : what was the rationale behind this change? Can you try and assess Julien's suggestions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants