Aggregate plots - totals incorrect

[cedlecomte]

From [email protected] on June 26, 2009 13:48:18

What steps will reproduce the problem? 1. Aggregate two or more ports onto a graph 2. 3. What is the expected output? What do you see instead? Expected output is a cumulative total of the DO's in any given LO next to
the legend. However this does not happen. It seems to be random, sometimes
when plotting aggregated values from 2 LO's it only shows the total of 1
DO, when plotting 5 it might show the total of 4 or 3. Note: the plot line
is fine (from what I can tell), the issue is with the totals on the legend. What version of the product are you using? On what operating system? 0.9 from this SVN. Please provide any additional information below. Example plot:
PO=Aggregated%20Physical%20Interfaces%20(data):450:100::1245715707:1245802107&
DO=1:ifInOctets_26:879&
DO=2:ifInOctets_26:888&
DO=3:ifOutOctets_26:879&
DO=4:ifOutOctets_26:888&
LO=1:1,2:aggr,percentile=95,factor=8:Incoming+Traffic&
LO=2:3,4:aggr,percentile=95,factor=8:Outgoing+Traffic&

Original issue: http://code.google.com/p/rtg2/issues/detail?id=10

[cedlecomte]

From [email protected] on July 06, 2010 11:16:54

Can you provide any example graphs showing these discrepancies, and if possible some sanitized datasets that we can use to reproduce?

[cedlecomte]

From [email protected] on July 07, 2010 06:31:13

It's a long time since I logged this, and I ended up fixing the problem myself. There is a diff attached, which I think is the fix I made. I can't tell you if this is complete or correct, since I'm not a developer by trade. It's not a big change, so you should be able to understand what I did.

Hope this helps.

Attachment: rtgplot-totalfix.diff

[cedlecomte]

From [email protected] on February 16, 2012 05:38:01

I have the same patch as you can see :

--- ../rtg2-read-only/src/rtgplot.c 2012-01-26 21:46:27.000000000 +0100
+++ src/rtgplot.c 2012-02-16 14:21:00.000000000 +0100
@@ -628,6 +628,7 @@
else if (head->timestamp > (*aggr)->timestamp) {
if (set->verbose >= DEBUG) fprintf(dfp, ".a");
last_head_rate = head->rate;

•       if ((head->timestamp + set->interval_2) <= (_aggr)->timestamp)
       (_aggr)->rate = last_aggr_rate + head->rate;
      if ((_aggr)->rate > aggr_rate->max) 
          aggr_rate->max = (_aggr)->rate;
  

  @@ -640,11 +641,12 @@
  (_aggr)->rate = (_aggr)->rate + head->rate;
  if ((_aggr)->rate > aggr_rate->max)
  aggr_rate->max = (*aggr)->rate;

•       aggr_rate->cur = (*aggr)->rate;
  

•       //aggr_rate->cur = (_aggr)->rate;
       head = head->next;
      aggr = &((_aggr)->next);
   }
  

  }
• (aggr_rate->cur)+= rate->cur;
  (aggr_rate->avg)+= rate->avg;
  (aggr_rate->total)+= rate->total;
  return;

I don't remember why i have add the line "if ((head->timestamp + set->interval_2) <= (_aggr)->timestamp)"
I check that and I commit the patch in the trunk.

[cedlecomte]

From [email protected] on February 16, 2012 05:38:37

Owner: [email protected]