Compile errors in rtgpoll.c on Solaris 10 (SPARC), Sun Studio 12

[cedlecomte]

From [email protected] on April 17, 2009 10:26:59

Compile errors in rtgpoll.c on Solaris 10 (SPARC), Sun Studio 12. I
reordered & grouped the errors/warnings:

"rtgpoll.c", line 8: warning: macro redefined: _REENTRANT
"rtgpoll.c", line 145: warning: implicit function declaration: init_snmp
"rtgpoll.c", line 242: warning: statement not reached
"rtgpoll.c", line 254: prototype mismatch: 2 args passed, 1 expected
cc: acomp failed for rtgpoll.c

• error (line 254) is standards conforming sigwait() requires
  -D_POSIX_PTHREAD_SEMANTICS

"rtgplot.c", line 153: warning: implicit function declaration: bzero
"rtgplot.c", line 245: warning: implicit function declaration: strcasestr
"rtgplot.c", line 462: undefined symbol: FUNCTION
"rtgplot.c", line 515: undefined symbol: FUNCTION
"rtgplot.c", line 549: undefined symbol: FUNCTION
"rtgplot.c", line 549: undefined symbol: FUNCTION
"rtgplot.c", line 615: undefined symbol: FUNCTION
"rtgplot.c", line 664: undefined symbol: FUNCTION
"rtgplot.c", line 767: undefined symbol: FUNCTION
"rtgplot.c", line 846: undefined symbol: FUNCTION
"rtgplot.c", line 935: undefined symbol: FUNCTION
"rtgplot.c", line 965: undefined symbol: FUNCTION
"rtgplot.c", line 1198: undefined symbol: FUNCTION
"rtgplot.c", line 1222: undefined symbol: FUNCTION
"rtgplot.c", line 1235: undefined symbol: FUNCTION
"rtgplot.c", line 1279: undefined symbol: FUNCTION
"rtgplot.c", line 1344: undefined symbol: FUNCTION
"rtgplot.c", line 1385: undefined symbol: FUNCTION
"rtgplot.c", line 1385: undefined symbol: FUNCTION

• bzero() is defined in <strings.h>, this needs to be added to rtg.h
• strcasestr is not available on Solaris
• FUNCTION is not defined in Sun Studio 12, use standard func

"rtgplot.c", line 810: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1005: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1016: warning: argument #1 is incompatible with prototype:
prototype: pointer to const long : "/usr/include/iso/time_iso.h",
line 89
argument : pointer to unsigned long
"rtgplot.c", line 1017: undefined struct/union member: tm_gmtoff
"rtgplot.c", line 1017: improper member use: tm_gmtoff
"rtgplot.c", line 1018: improper member use: tm_gmtoff
"rtgplot.c", line 1018: improper member use: tm_gmtoff
"rtgplot.c", line 1066: warning: argument #1 is incompatible with prototype:
prototype: pointer to const long : "/usr/include/iso/time_iso.h",
line 89
argument : pointer to unsigned long
"rtgplot.c", line 1067: undefined struct/union member: tm_gmtoff
"rtgplot.c", line 1067: improper member use: tm_gmtoff

• tm_gmtoff is not included in struct tm on Solaris <iso/time_iso.h>

"rtgplot.c", line 1056: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1088: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1107: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1119: warning: argument #1 is incompatible with prototype:
prototype: pointer to const long : "/usr/include/iso/time_iso.h",
line 89
argument : pointer to unsigned long
"rtgplot.c", line 1147: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1163: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1188: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1208: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 365
argument : pointer to char
"rtgplot.c", line 1212: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
"rtgplot.c", line 1214: warning: argument #5 is incompatible with prototype:
prototype: pointer to unsigned char : "/opt/local/include/gd.h",
line 363
argument : pointer to char
cc: acomp failed for rtgplot.c
gmake[2]: *** [rtgplot.o] Error 2

I'm willing to test on our Sun system when patches are ready.

Original issue: http://code.google.com/p/rtg2/issues/detail?id=7