Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to first ABCI++ celestia branch #204

Closed
evan-forbes opened this issue Feb 8, 2022 · 0 comments · Fixed by #214
Closed

Upgrade to first ABCI++ celestia branch #204

evan-forbes opened this issue Feb 8, 2022 · 0 comments · Fixed by #214
Assignees

Comments

@evan-forbes
Copy link
Member

Currently the app and core utilize the ABCI to communicate. This limits the possible solutions we can pursue for important features such as #455, #454, and #77. While the current implementation of ABCI++ is not entirely stable, we should incorporate it so that we can begin to work on solutions to issues above.

This will involve

  • using the master branch (or whatever the abci++ branch ends up being) of celestia-core
  • Refactoring the PreprocessTxs method to PrepareProposal
@evan-forbes evan-forbes self-assigned this Feb 11, 2022
@evan-forbes evan-forbes moved this to TODO in Celestia Node Feb 11, 2022
@evan-forbes evan-forbes moved this from TODO to In Progress in Celestia Node Feb 11, 2022
@evan-forbes evan-forbes moved this from In Progress to In Review in Celestia Node Feb 21, 2022
Repository owner moved this from In Review to Done in Celestia Node Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant