Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using a different way to exclude test from the race detector #2303

Open
evan-forbes opened this issue Aug 17, 2023 · 2 comments
Open
Labels
proposal item is not yet actionable and is suggesting a change that must first be agreed upon

Comments

@evan-forbes
Copy link
Member

until we fix #1369, we have to continue to exclude some integration tests. This used to be done using the short flag, but is now done by using make.

in the past we've also used a build flag and init function. This allows for a similar dev ux to using a short flag like before, which might be beneficial since we can define which tests are skipped in the test itself instead of relying on an external bash script.

@evan-forbes evan-forbes added the proposal item is not yet actionable and is suggesting a change that must first be agreed upon label Aug 17, 2023
@rootulp
Copy link
Collaborator

rootulp commented Aug 17, 2023

celestia-node appears to use a !race build flag here and here that may be worth investigating.

@cmwaters
Copy link
Contributor

Just as food for thought: celestia-app is basically single threaded so why do we need race tests at all?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal item is not yet actionable and is suggesting a change that must first be agreed upon
Projects
None yet
Development

No branches or pull requests

3 participants