Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement end to end tests that attempt to propose invalid blocks #233

Closed
Tracked by #514 ...
evan-forbes opened this issue Mar 8, 2022 · 2 comments
Closed
Tracked by #514 ...
Labels
testing items that are strictly related to adding or extending test coverage

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Mar 8, 2022

With the introduction of ABCI++ #231, we are adding checks to proposal blocks. while we have tests to ensure that invalid proposals get rejected, we don't have an end to end test for this specific case.

@evan-forbes
Copy link
Member Author

one strategy to accomplish this in both an integration or e2e test is to simply wrap the application and overwrite the prepare proposal method

@evan-forbes
Copy link
Member Author

can close as completed with the addition of the malicious package, which adds the ability to propose and sign invalid blocks.

ensuring that ProcessProposal is always called is a different issue, and the rest of the test cases are covered by existing correctness testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

1 participant