Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use NewClient instead of Dial when starting a gRPC connection #1587

Open
rach-id opened this issue Jan 13, 2025 · 0 comments
Open

use NewClient instead of Dial when starting a gRPC connection #1587

rach-id opened this issue Jan 13, 2025 · 0 comments
Labels
good first issue Good for newcomers

Comments

@rach-id
Copy link
Member

rach-id commented Jan 13, 2025 •
edited
Loading 

          The problem with this is that it uses an address from the config which has a tcp prefix and when used with NewClient it fails to connect.

So, changing this would mean reparsing the provided address and separating it to fmt.Sprintf("%s:%s", host, port).

We can create an issue to do it along with the other gRPC endpoint for consistency instead of touching both in here

Originally posted by @rach-id in #1513 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rach-id