store: Head of store needs to be the *contiguous* head of the store #201
Comments
|
Needs a test on the store to ensure that an Append that occurs that is non-adjacent to the highest head written to disk would still be successfully written to the disk but NOT reflected in |
cristaloleg
added a commit
that referenced
this issue
Oct 22, 2024
## Overview The main idea of this PR is to make `Store[H].Head` working properly, to be precise: returning head that was written to the disk (*). Along with that `heightSub.height` is increased monotonically to prevent bugs when we have store appends out of order. To test everything I'm adding 2 new tests: one that verifies out of order appends and another when which does this concurrently. Which helped to find 2 or even 3 edge cases during coding. Fixes #201
|
Reopening due to revert. |
|
After a yesterday's discussion with Hlib:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently in main, the
headof the store is updated when an Append is done (via #186) because the assumption was that the syncer only does contiguous Appends to the store. This is actually not true because the syncer can write to the store via Append insideincomingNetHeadwhereby a header that comes in through headersub (or via p2p.Exchange request) can be verified non-adjacently and then applied to the store if it passes the non-adjacent verification.We need to fix this by ensuring that the store knows of its own highest header that is contiguous (meaning all headers below the
headare adjacent).Note: once the
Tail()method is implemented, theheadof the store should be the highest header that is contiguous all the way down to theTail().Height()The text was updated successfully, but these errors were encountered: