Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GifImage#loadFrom(File) has a resource leak #2

Open
AlexanderSchuetz97 opened this issue Jun 13, 2024 · 0 comments
Open

GifImage#loadFrom(File) has a resource leak #2

AlexanderSchuetz97 opened this issue Jun 13, 2024 · 0 comments

Comments

@AlexanderSchuetz97
Copy link

public int loadFrom(File file) throws FileNotFoundException {
if (!file.exists()) throw new FileNotFoundException("File does not exist");
return loadFrom(new FileInputStream(file));
}

The FileInputStream is leaked
Change this to:

public int loadFrom(File file) throws FileNotFoundException {
if (!file.exists()) throw new FileNotFoundException("File does not exist");
try(FileInputStream fais = new FileInputStream(file)) {
return this.loadFrom(fais);
}
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant