Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to aggregate parameters and hyperparameters for mixed potentials #38

Open
jrdegreeff opened this issue Apr 18, 2022 · 0 comments
Open

Comments

@jrdegreeff
Copy link
Member

Currently the parameter interface is unimplemented for LinearCombinationPotential. The simplest way to implement this would be to concatenate the results from the subpotentials and possibly annotate with some metadata to disambiguate. The problem with this is that it doesn't allow any parameters to be logically shared between subpotentials. To do this we would need a stronger notion of parameters, likely involving an extra layer of abstraction through a parameter struct. This would add a good amount of complexity, so if it's a desired feature, we should spend more time considering the design before implementing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant