Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Public API for checking network connection #103

Open
chadxz opened this issue Oct 30, 2018 · 1 comment
Open

Public API for checking network connection #103

chadxz opened this issue Oct 30, 2018 · 1 comment
Labels
enhancement help wanted semver-minor Contains backward-compatible features

Comments

@chadxz
Copy link
Owner

chadxz commented Oct 30, 2018

Originally reported in #101

ping. You have this undocumented, but it is done simply with events._ws.ping(). This makes it easy to detect a broken connection. I have not found another way to detect broken connections. However, maybe there is a better way?
@chadxz chadxz mentioned this issue Oct 30, 2018
Open
@chadxz
Copy link
Owner Author

chadxz commented Oct 31, 2018

ping is part of the underlying ws library. It sounds like the use case here is to periodically check the health of the connection without taking an actual action. Seems like a good thing to have.

We can easily expose this on the public API!

@chadxz chadxz added enhancement help wanted semver-minor Contains backward-compatible features labels Oct 31, 2018
@chadxz chadxz mentioned this issue Oct 31, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted semver-minor Contains backward-compatible features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose ping. Needs tests and review. chadxz/awry
1 participant
@chadxz