Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic processing should be managed by nmr-load-save #2728

Closed
lpatiny opened this issue Oct 29, 2023 · 0 comments · Fixed by #2737
Closed

Automatic processing should be managed by nmr-load-save #2728

lpatiny opened this issue Oct 29, 2023 · 0 comments · Fixed by #2737
Assignees

Comments

@lpatiny
Copy link
Member

lpatiny commented Oct 29, 2023

Automatic processing may be very specific to a kind of spectrum and the code that decides which filter to add should not be in NMRium but in nmr-load-save.

image

This means that NMRium needs to send the following preferences to nmr-load-save:

 {
      "1H": [
        {
          "name": "digitalFilter",
          "label": "Digital Filter",
          "value": {},
          "flag": true
        },
        {
          "name": "apodization",
          "label": "Apodization",
          "value": {},
          "flag": false
        },
        {
          "name": "zeroFilling",
          "label": "Zero Filling",
          "value": {},
          "flag": true
        },
        {
          "name": "fft",
          "label": "FFT",
          "value": {},
          "flag": true
        },
        {
          "name": "phaseCorrection",
          "label": "Phase correction",
          "value": {},
          "flag": true
        }
      ],
      "13C": [
        {
          "name": "digitalFilter",
          "label": "Digital Filter",
          "value": {},
          "flag": true
        },
        {
          "name": "apodization",
          "label": "Apodization",
          "value": {},
          "flag": true
        },
        {
          "name": "zeroFilling",
          "label": "Zero Filling",
          "value": {},
          "flag": true
        },
        {
          "name": "fft",
          "label": "FFT",
          "value": {},
          "flag": true
        },
        {
          "name": "phaseCorrection",
          "label": "Phase correction",
          "value": {},
          "flag": true
        }
      ]
}

and when loading nmr-load-save could add the required filter (and some other one) if the corresponding flag is 'true'.

We will also need to extend those preferences to 2D but likely not only to the nuclei (1H,13C) but also to specific pulse sequence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants