-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit tests for line_detection #26
Comments
start looking here |
build a unit test for generic_linedetection that tries every parameter value and see if it breaks anything (testing our validation function). Not really something we need, but just an exercise in learning testing |
ok, I just thought of a way to test performance of different line detection nodes using Gazebo runs. I need @l0g1x to help set this up. This is how it works:
This way, we can make like 5-6 different line detection nodes (each with different filters or tweaked values), and we run them and check which is better. We can then keep improving the line detection (and we KNOW that we're improving because we have a metric to compare it to). |
I think this should take top priority in line detection. If we don't have this, then it's pointless to try to figure out which line detection algorithm is better (because we can't measure it currently, we can only eyeball it and guess). For example, is backprojection grass filtering + hough better than just using grayscale + threshold + RANSAC? We don't know, because we can't measure it currently. But with this, we CAN. |
start coming up with things to test the line_detection node.
Maybe testing valid camera input, training image input, valid parameters from dynamic_reconfigure...
Can't think of ways to unit test output though... Needs more head-scratching
The text was updated successfully, but these errors were encountered: