Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to handle additional manual notification providers #138

Open
2 tasks done
AdmiringWorm opened this issue Feb 22, 2024 · 4 comments
Open
2 tasks done

Add support to handle additional manual notification providers #138

AdmiringWorm opened this issue Feb 22, 2024 · 4 comments
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features

Comments

@AdmiringWorm
Copy link
Member

Checklist

  • I have verified this is the correct repository for opening this issue.
  • I have verified no other issues exist related to my request.

Is Your Feature Request Related To A Problem? Please describe.

As part of our releases, we have certain places that needs to be done manually.

Describe The Solution. Why is it needed?

It would be nice to have additional providers added that won't be sending any notifications, but rather would just output the information needed to be posted to the console instead, possibly with information about what needs to be done.

The providers I had in mind for this that isn't implemented would be LinkedIn, Reddit and possibly Facebook (Bluesky as well until it is automated).

This should probably prompt the user to confirm that it has been done before continuing to the next notification provider.

Additional Context

No response

Related Issues

No response

@AdmiringWorm AdmiringWorm added Improvement Issues that enhances existing functionality, or adds new features 0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue labels Feb 22, 2024
@gep13
Copy link
Member

gep13 commented Feb 3, 2025

What are your thoughts on this one? Now that we are introducing the --dry-run flag, I think that this one now might be covered? Right?

@AdmiringWorm
Copy link
Member Author

No, it is different.

This is to add support for providers that we can not automate, but we can create local (or output) the notes that should be posted in these location.

For instance, output the necessary notes that should be posted manually on Linkedin, reddit, etc...

@gep13
Copy link
Member

gep13 commented Feb 3, 2025

But can't we copy/paste the output from running --dry-run=true and then use that as a the basis for the other notifications?

@AdmiringWorm
Copy link
Member Author

If/When those are the same, then yes.

But there are times where these will be different, and you have to figure out manually on what needs to be added/changed. If Cake.Recipe decided that for us, it would make it less likely for an error to made.

This manual notification provider could also include any announcement emails as well (maybe interactively by choosing what to include, not sure).

With everything said though, I do not believe we would include anything in the next release, as there probably are some discussions needed to figure out what to include, how to include it, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - _Triaging Issue is accepted, but a milestone has yet to be added for the issue Improvement Issues that enhances existing functionality, or adds new features
Projects
None yet
Development

No branches or pull requests

2 participants