(#174) Don't always push latest tag to docker #183
Merged
+13
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Docker build to only set latest tag when it is the latest build. Previously we would set the latest tag on every tagged build which means that pre-release and support builds would get tagged as latest. This corrects that.
gep13
force-pushed
the
174-docker-latest
branch
from
3d4cf50 to
92be168
Compare
|
@corbob I have just taken this for a spin, and this appears to be working as expected. Thanks for getting this done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Update Docker build to only set latest tag when it is the latest build.
Motivation and Context
Previously we would set the latest tag on every tagged build which means that pre-release and support builds would get tagged as latest. This corrects that.
Testing
chocolatey/chocorepository on the develop branch.docker.cakefile to remove lines 47-50 (call toDockerBuild) as my VM does not have docker installed on it..\build.bat --target=docker --verbosity=diagnosticDockerTagAsLatestis:Skipping task: Skipping because this isn't a tagged full release build.git checkout master.\build.bat --target=docker --verbosity=diagnosticDockerTagAsLatestis:Skipping task: Skipping because Docker Credentials were not provided.(This indicates that the tag on the master branch was correctly detected and the task was skipped for the next criteria)git checkout support.\build.bat --target=docker --verbosity=diagnosticDockerTagAsLatestis:Skipping task: Skipping because this isn't a tagged full release build.As for the
DockerManifesttask, the testing was done by debugging the script and stepping through it to ensure it did not output things.Operating Systems Testing
Windows 11
Change Types Made
Change Checklist
Related Issue