Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

files with multiple extensions lose an extension (.tar.gz -> .gz) #58

Open
Baisang opened this issue Jan 10, 2018 · 4 comments
Open

files with multiple extensions lose an extension (.tar.gz -> .gz) #58

Baisang opened this issue Jan 10, 2018 · 4 comments

Comments

@Baisang
Copy link
Contributor

Baisang commented Jan 10, 2018

files with multiple extensions are not served properly -- they lose an extension

example:

https://i.fluffy.cc/L6j2RJm6QR5LRLThdSQ4Ddd9X7Zv76JM.html

@Baisang
Copy link
Contributor Author

Baisang commented Jan 10, 2018

@chriskuehl unless you're really bored, I can get around to doing this within the next week or so

@chriskuehl
Copy link
Owner

chriskuehl commented Jan 10, 2018

I don't really know how to solve this. How do you differentiate between what is part of an extension and what is just a dot in the filename?

@chriskuehl
Copy link
Owner

Implementing #61 might be the best approach to this (although it will only work for backends like S3).

@chriskuehl
Copy link
Owner

Good news is #61 is implemented, so this is at least partially fixed for anyone using the S3 backend -- when downloading via a browser, the file should download with the original name (including the full extension).

It still might be good to keep both extensions in the file storage name though, since that's still what will be used if you e.g. wget the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants