Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include cripsy forms (and floppyforms as well) by default? #2

Open
chrislawlor opened this issue Apr 18, 2013 · 0 comments
Open

Include cripsy forms (and floppyforms as well) by default? #2

chrislawlor opened this issue Apr 18, 2013 · 0 comments
Labels

Comments

@chrislawlor
Copy link
Owner

Currently, crispyforms and floppyforms are commented out in the base settings module, as well as in the base requirements file. They were originally meant to be included in this manner so that they were easily enabled, suggested to be used, but not on by default.

However, the included registration/login.html uses the crispy template filter from the crispyforms library, and therefore results in an error if at least the crispyforms library is not installed by default.

The choice therefore is to do one of the following:

  1. Enable at least the crispyforms library by default
  2. Re-work the login.html template to not use the crispy filter
  3. Remove the registration templates altogether.

I'm not convinced that the existing login template provides much value, and personally I don't use the crispyforms library enough to warrant it's inclusion as installed by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant