Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create transactions-of-the-philological-society.csl #7421

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alexei-Kassian
Copy link

Style for the Wiley journal 'Transactions of the Philological Society' (TPhS)

Style for the Wiley journal 'Transactions of the Philological Society' (TPhS)
Copy link

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

Copy link

😟 There are some issues with your submission.

1 test failed

transactions-of-the-philological-society: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (6) to be greater than et-al-use-first (6)

Please check the test report for details.

@POBrien333
Copy link
Contributor

Have a look at our [https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md#csl-style-repository-requirements](style requirements).
Can you add the template style use used into the info section? (point 8)
You could also add a title-short with TPhS just below the title if you wanted. (see point 1)

The style is not validating as you have an error with your et-al rules.
At first glance I cannot find that the bibliography needs et-al. What is the expected bevahiour? Then I can suggest the change.

@Alexei-Kassian
Copy link
Author

My TPhS template was based on 'West European Politics' https://www.zotero.org/styles/west-european-politics.
I'm not a programmer, I'm trying to do my best.

  1. 'et al' rules currently works fine. It's needed in bibliographic description if a publication has more than 5 co-authors. In such a case, only first 5 names are to be listed followed by 'et al.' E.g.:

Smith, Alex, Alex Jones, Alex Williams, Alex Taylor, Alex Brown, Alex Davies, 2025. 'Issues on ...'

Smith, Alex, Alex Jones, Alex Williams, Alex Taylor, Alex Brown et al., 2025. 'Issues on ...'

  1. "et al." should not be in small caps (authors' surnames & names are in small caps). But I failed to override small caps for 'et al.'

  2. The same problem with small caps. Some books have no authors, but only editors. E.g.:

Smith, Alex (ed.), 2025. English dictionary. Amsterdam: Elsevier.

Currently "ed." is in small caps (as "Smith, Alex"), but it should not be.

<rights license="http://creativecommons.org/licenses/by-sa/3.0/">This work is licensed under a Creative Commons Attribution-ShareAlike 3.0 License</rights>
</info>
<macro name="editor">
<names variable="editor" font-variant="normal" vertical-align="baseline">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove font-variant="normal" throughout your style unless it's be design (usually never is)

<info>
<title>Transactions of the Philological Society</title>
<id>http://www.zotero.org/styles/transactions-of-the-philological-society</id>
<link href="http://www.zotero.org/styles/transactions-of-the-philological-society" rel="self"/>

This comment was marked as resolved.

@Alexei-Kassian
Copy link
Author

Done (I don't know how to upload a new version). It doesn't help, "ed." and "et al." remain in small caps.

@Alexei-Kassian
Copy link
Author

I uploaded a new version.

Copy link

github-actions bot commented Feb 1, 2025

😟 There are some issues with your submission.

1 test failed

transactions-of-the-philological-society: name nodes must have valid et-al-min and et-al-use-first attributes

expected et-al-min (6) to be greater than et-al-use-first (6)

Please check the test report for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants