Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP: No "create link" button - can't create links with custom texts #110

Closed
2 tasks
tiblu opened this issue Nov 6, 2018 · 6 comments
Closed
2 tasks

EP: No "create link" button - can't create links with custom texts #110

tiblu opened this issue Nov 6, 2018 · 6 comments
Assignees
Labels
enhancement Making an existing feature better.

Comments

@tiblu
Copy link
Member

tiblu commented Nov 6, 2018

Overview

There is no "create link" button to enable creating links with custom texts.
There used to be, but EP removed it in favor auto-detecting links.

TODO

  • Find a way to enable links with custom text while keeping the auto-detect working. Also auto-detected links should be editable to create custom text.
  • Check DOCX export, make sure links are exported.
@anettlinno
Copy link
Collaborator

Triage 51. Etherpad should have hyperlink plugins but we need to check if these are updated. Est. dev. time is 2 days.
Sending to development.

@ilmartyrk
Copy link
Member

Possibly can use https://github.com/inicio/ep_embedded_hyperlinks

@KatiVellak
Copy link

Discussed on Triage, no further legal comments. User friendly approach.

@anettlinno anettlinno added the enhancement Making an existing feature better. label Nov 9, 2021
@ilmartyrk ilmartyrk self-assigned this Feb 9, 2022
@tiblu tiblu assigned tiblu and unassigned ilmartyrk Feb 9, 2022
@tiblu
Copy link
Member Author

tiblu commented Feb 9, 2022

Progress

ep_embedded_hyperlinks2

  • NO links in HTML export
  • The link popup appears in a random place.
  • Hyperlink button location on toolbar not configurable.
  • Cannot remove a hyperlink from a piece of text. You can delete the text, but not just remove.
  • Beware to check copy-paste links from other pads, see if these work.

image

Sent out a question to the maintainer about the future of the project - citizenos/ep_embedded_hyperlinks2#14 (comment)
and Citizen OS now maintains it - https://github.com/citizenos/ep_embedded_hyperlinks2

TODO

In order of importance:

  • Links in HTML export
    • Tests!
  • Make sure copy-pasting links works.
  • UX - positioning of the link dialog
  • Remove a link
  • Make link button location configurable on the toolbar

@anettlinno
Copy link
Collaborator

Tested. Works nicely but hyperlink is hidden in the menu. I would recommend to change it to footnote or any other menu item that is less frequently used. Additionally I would prefer if hyperlinked page would open in new window and I would still stay on COS topic. @ilmartyrk

@errotu
Copy link

errotu commented May 16, 2022

Thanks a lot for your work! The updated version (with working HTML export) is not yet published on npm, is it? Are you planning to do so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Making an existing feature better.
Projects
None yet
Development

No branches or pull requests

5 participants